Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use default-app behavior in packaged apps #16310

Merged
merged 1 commit into from Jan 15, 2019

Conversation

@miniak
Copy link
Contributor

commented Jan 7, 2019

Description of Change

unify the behavior between default app and packaged apps:

  • create default application menu unless the app has one
  • default window-all-closed handling unless the app handles the event

Checklist

Release Notes

Notes: Unified behavior between the default app and packaged apps (application menu / window-all-closed handling)

@miniak miniak added the wip label Jan 7, 2019

@miniak miniak self-assigned this Jan 7, 2019

@miniak miniak requested review from as code owners Jan 7, 2019

@miniak miniak changed the title feat: use default-app behavior in packaged apps (default menu / window-all-closed handling feat: use default-app behavior in packaged apps Jan 7, 2019

@miniak miniak force-pushed the miniak/default-app-behavior branch from 9a27ad8 to ae6480a Jan 7, 2019

@codebytere codebytere changed the title feat: use default-app behavior in packaged apps [wip] feat: use default-app behavior in packaged apps Jan 7, 2019

@miniak miniak force-pushed the miniak/default-app-behavior branch from ae6480a to 548b7bf Jan 7, 2019

Show resolved Hide resolved lib/browser/init.js Outdated

@miniak miniak force-pushed the miniak/default-app-behavior branch 5 times, most recently from 2ef3347 to 7a716c7 Jan 8, 2019

@miniak miniak removed the wip label Jan 8, 2019

@miniak miniak changed the title [wip] feat: use default-app behavior in packaged apps feat: use default-app behavior in packaged apps Jan 8, 2019

@miniak miniak force-pushed the miniak/default-app-behavior branch from 7a716c7 to 0e6bde1 Jan 8, 2019

@miniak miniak added the wip label Jan 8, 2019

@miniak miniak changed the title feat: use default-app behavior in packaged apps [wip] feat: use default-app behavior in packaged apps Jan 8, 2019

@miniak miniak force-pushed the miniak/default-app-behavior branch 4 times, most recently from cfb5345 to 50e9528 Jan 8, 2019

@miniak miniak changed the title [wip] feat: use default-app behavior in packaged apps feat: use default-app behavior in packaged apps Jan 10, 2019

@miniak miniak removed the wip label Jan 10, 2019

@miniak miniak force-pushed the miniak/default-app-behavior branch from 50e9528 to f908d88 Jan 10, 2019

@miniak miniak requested review from nornagon, ckerr and MarshallOfSound Jan 10, 2019

@miniak miniak requested review from codebytere and deepak1556 Jan 10, 2019

@miniak miniak force-pushed the miniak/default-app-behavior branch from f908d88 to cfb5345 Jan 10, 2019

Show resolved Hide resolved docs/api/menu.md Outdated

@miniak miniak force-pushed the miniak/default-app-behavior branch 3 times, most recently from 32d564e to cbe5a16 Jan 10, 2019

Show resolved Hide resolved docs/api/process.md Outdated
Show resolved Hide resolved docs/api/menu.md Outdated
Show resolved Hide resolved docs/api/menu.md Outdated
Show resolved Hide resolved lib/browser/init.js Outdated
Show resolved Hide resolved default_app/main.js
Show resolved Hide resolved spec/fixtures/api/default-menu/main.js Outdated

@miniak miniak force-pushed the miniak/default-app-behavior branch 2 times, most recently from 001b989 to 82a6ac8 Jan 14, 2019

Show resolved Hide resolved docs/api/menu.md Outdated

@miniak miniak force-pushed the miniak/default-app-behavior branch from 82a6ac8 to 6d8576c Jan 14, 2019

@miniak miniak removed the request for review from ckerr Jan 15, 2019

@miniak miniak force-pushed the miniak/default-app-behavior branch from 6d8576c to a2fec4b Jan 15, 2019

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

@electron/docs can you please review this?

@alexeykuzmin alexeykuzmin merged commit 23d44e3 into master Jan 15, 2019

24 of 25 checks passed

Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20190115.12 succeeded
Details
electron-arm64-testing Build #20190115.10 succeeded
Details
electron-lint Build #20190115.24 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 15, 2019

Release Notes Persisted

Unified behavior between the default app and packaged apps (application menu / window-all-closed handling)

@alexeykuzmin alexeykuzmin deleted the miniak/default-app-behavior branch Jan 15, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

feat: use default-app behavior in packaged apps (electron#16310)
Unify the behavior between default app and packaged apps:
- create default application menu unless the app has one
- default window-all-closed handling unless the app handles the event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.