New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register accelerator if role has no registerAccelerator (backport: 4-0-x) #16314

Merged
merged 2 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

trop bot commented Jan 8, 2019

Backport of #16309

See that PR for details.

Notes: Fixed an issue whereby registerAccelerator was being set to the registerAccelerator property of its role even when registerAccelerator was undefined.

@trop trop bot requested a review from electron/reviewers as a code owner Jan 8, 2019

@trop trop bot referenced this pull request Jan 8, 2019

Merged

fix: register accelerator if role has no registerAccelerator #16309

6 of 6 tasks complete

@trop trop bot added 4-0-x backport labels Jan 8, 2019

@jkleinsc jkleinsc merged commit 0b6cc93 into electron:4-0-x Jan 8, 2019

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 8, 2019

Release Notes Persisted

Fixed an issue whereby registerAccelerator was being set to the registerAccelerator property of its role even when registerAccelerator was undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment