New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Chromium 72.0.3626.52 #16334

Merged
merged 58 commits into from Jan 22, 2019

Conversation

Projects
None yet
6 participants
@nornagon
Copy link
Contributor

nornagon commented Jan 9, 2019

Description of Change

Ref https://github.com/electron/electron/projects/16

Checklist

Release Notes

Notes: upgrade to Chromium 72.0.3626.52

@nornagon nornagon requested review from electron/notifications as code owners Jan 9, 2019

@nornagon nornagon force-pushed the chromium-upgrade/72 branch from 2ea8c2b to 6747530 Jan 9, 2019

@nornagon nornagon requested review from electron/browserview as code owners Jan 9, 2019

@nornagon nornagon force-pushed the chromium-upgrade/72 branch 2 times, most recently from d26ed3c to 89bb3b7 Jan 10, 2019

api_web_contents_->web_contents()->AttachToOuterWebContentsFrame(
base::WrapUnique<content::WebContents>(embedder_web_contents_),
guest_web_contents->AttachToOuterWebContentsFrame(
base::WrapUnique<content::WebContents>(guest_web_contents),

This comment has been minimized.

@nornagon

nornagon Jan 10, 2019

Author Contributor

this looks like it's changing behaviour, is that intentional?

This comment has been minimized.

@deepak1556

deepak1556 Jan 10, 2019

Member

Yup its based on the AttachToOuterWebContentsFrame api change in https://chromium-review.googlesource.com/c/chromium/src/+/1301843.

From

// Attaches this inner WebContents to its container frame
// |outer_contents_frame| in |outer_web_contents|.

to

// Attaches |current_web_contents| to its container frame
// |outer_contents_frame|.

@nornagon nornagon force-pushed the chromium-upgrade/72 branch 2 times, most recently from 81d85c8 to fa2e26f Jan 11, 2019

void WebContents::DetachFromOuterFrame() {
// See detach_webview_frame.patch on how to detach.
auto* impl = static_cast<content::WebContentsImpl*>(web_contents());
impl->GetRenderManagerForTesting()->RemoveOuterDelegateFrame();

This comment has been minimized.

@deepak1556

deepak1556 Jan 12, 2019

Member

Probably a better way to access the frame host manager would be via FrameTreeNode https://cs.chromium.org/chromium/src/content/browser/frame_host/frame_tree_node.h?l=106 . Based on the comments GetRenderManagerForTesting might be removed soon.

@nornagon nornagon force-pushed the chromium-upgrade/72 branch from 45b7838 to 4910487 Jan 14, 2019

@nornagon nornagon changed the title [wip] feat: upgrade to Chromium 72.0.3626.52 feat: upgrade to Chromium 72.0.3626.52 Jan 14, 2019

@nornagon nornagon requested a review from electron/docs as a code owner Jan 15, 2019

nornagon and others added some commits Jan 11, 2019

include glib.h in atom_main_delegate
it was complaining about 'undeclared identifier 'TRUE''
roll node
to pick up libuv compile fix on windows
fix: detach webview instead of destroying it
Chromium no longer cleans up everything when a guest webcontents is
destroyed, we have to force detaching it and let Chromium destroy everything.
fix: add patch to disable dcheck in inter_process_time_ticks_converte…
…r.cc

I'm seeing crashes on Windows when runnings tests for serviceWorker, the
reason why the dcheck failed is unclear.

@nornagon nornagon force-pushed the chromium-upgrade/72 branch from 05e6998 to c0f6a44 Jan 22, 2019

@jkleinsc
Copy link
Contributor

jkleinsc left a comment

LGTM

@BinaryMuse

This comment has been minimized.

Copy link
Member

BinaryMuse commented Jan 22, 2019

@BinaryMuse BinaryMuse merged commit 1918e76 into master Jan 22, 2019

3 of 6 checks passed

appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
ci/circleci: linux-checkout CircleCI is running your tests
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 22, 2019

Release Notes Persisted

Upgraded to Chromium 72.0.3626.52.

@BinaryMuse BinaryMuse deleted the chromium-upgrade/72 branch Jan 22, 2019

@MarshallOfSound MarshallOfSound restored the chromium-upgrade/72 branch Jan 22, 2019

MarshallOfSound added a commit that referenced this pull request Jan 22, 2019

@MarshallOfSound MarshallOfSound deleted the chromium-upgrade/72 branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment