New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly determine if WebContents is offscreen in WebContentsDelegate (backport: 4-0-x) #16340

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Jan 9, 2019

Backport of #16329

See that PR for details.

Notes: Changed the file dialog presented by inputs with the type file to use sheets on macOS instead of detached modals.

@trop trop bot requested a review from electron/reviewers as a code owner Jan 9, 2019

@trop trop bot added 4-0-x backport labels Jan 9, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Jan 10, 2019

Merging as MAS failure is known flake

@jkleinsc jkleinsc merged commit 1089dd3 into electron:4-0-x Jan 10, 2019

20 of 21 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 10, 2019

Release Notes Persisted

Changed the file dialog presented by inputs with the type file to use sheets on macOS instead of detached modals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment