Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 'use strict' to default app sources #16346

Merged
merged 1 commit into from Jan 10, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 10, 2019

Follow up to #14721

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak requested a review from a team January 10, 2019 15:30
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miniak miniak self-assigned this Jan 10, 2019
@miniak
Copy link
Contributor Author

miniak commented Jan 10, 2019

@jkleinsc can you please merge?

@miniak miniak force-pushed the miniak/default-app-use-strict branch from 8ba2de6 to 69f2e2e Compare January 10, 2019 16:02
@alexeykuzmin alexeykuzmin merged commit 102d8fe into master Jan 10, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 10, 2019

No Release Notes

@alexeykuzmin alexeykuzmin deleted the miniak/default-app-use-strict branch January 10, 2019 19:54
akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants