New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 'use strict' to default app sources #16346

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
5 participants
@miniak
Copy link
Contributor

miniak commented Jan 10, 2019

Follow up to #14721

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak requested a review from electron/docs as a code owner Jan 10, 2019

@jkleinsc
Copy link
Contributor

jkleinsc left a comment

LGTM

@miniak miniak self-assigned this Jan 10, 2019

@miniak

This comment has been minimized.

Copy link
Contributor

miniak commented Jan 10, 2019

@jkleinsc can you please merge?

@miniak miniak force-pushed the miniak/default-app-use-strict branch from 8ba2de6 to 69f2e2e Jan 10, 2019

@ckerr

ckerr approved these changes Jan 10, 2019

@alexeykuzmin alexeykuzmin merged commit 102d8fe into master Jan 10, 2019

20 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 10, 2019

No Release Notes

@alexeykuzmin alexeykuzmin deleted the miniak/default-app-use-strict branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment