New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix the build with enable_run_as_node disabled (backport: 4-0-x) #16367

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Jan 11, 2019

Backport of #15711

See that PR for details.

Notes: no notes

@trop trop bot requested a review from electron/reviewers as a code owner Jan 11, 2019

@trop trop bot referenced this pull request Jan 11, 2019

Merged

build: fix the build with enable_run_as_node disabled #15711

3 of 3 tasks complete

@trop trop bot added 4-0-x backport labels Jan 11, 2019

@miniak

miniak approved these changes Jan 11, 2019

@alexeykuzmin alexeykuzmin merged commit 2e69f0a into electron:4-0-x Jan 12, 2019

20 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 12, 2019

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment