New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redo size -> length #16370

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

codebytere commented Jan 11, 2019

Description of Change

electron-bot reverted this somehow

cc @BinaryMuse @ckerr

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from electron/reviewers as a code owner Jan 11, 2019

@ckerr

ckerr approved these changes Jan 11, 2019

Copy link
Member

ckerr left a comment

🤔

Approved, but I'd love to know how that got reverted in the first place.

@codebytere codebytere changed the title redo: size -> length chore: redo size -> length Jan 11, 2019

@codebytere codebytere merged commit e2b1394 into master Jan 11, 2019

14 of 20 checks passed

appveyor: win-ia32-debug Waiting for AppVeyor build to complete
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-debug Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
ci/circleci: linux-arm-testing CircleCI is running your tests
Details
ci/circleci: linux-arm64-testing CircleCI is running your tests
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 11, 2019

No Release Notes

@codebytere codebytere deleted the fix-length branch Jan 11, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment