New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit IPC event in correct context if isolation and sandbox enabled (backport: 4-0-x) #16376

Merged
merged 2 commits into from Jan 12, 2019

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

trop bot commented Jan 12, 2019

Backport of #16352

See that PR for details.

Notes: Fixed delivery of IPC events to renderer processes when both contextIsolation and sandbox are enabled.

Alex Garbutt added some commits Jan 8, 2019

fix: emit IPC event in correct context if isolation and sandbox enabled
IPC events were not being delivered to renderer processes when both
`contextIsolation` and `sandbox` were enabled. This is because the
`AtomSandboxedRenderFrameObserver` class was incorrectly using the
`MainWorldScriptContext`, rather than conditionally selecting the
context based on if isolation was enabled.

Fixes #11922

@trop trop bot requested a review from electron/reviewers as a code owner Jan 12, 2019

@trop trop bot added 4-0-x backport labels Jan 12, 2019

@miniak

miniak approved these changes Jan 12, 2019

@alexeykuzmin alexeykuzmin merged commit f3bbb5a into electron:4-0-x Jan 12, 2019

20 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 12, 2019

Release Notes Persisted

Fixed delivery of IPC events to renderer processes when both contextIsolation and sandbox are enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment