Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windowmenu role did not show the window list on macOS #16387

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
3 participants
@miniak
Copy link
Contributor

commented Jan 14, 2019

Description of Change

Fix #15912 properly. The whole menu needs to have window role set, as the OS appends the window list at the end of the submenu instead of replacing a single menu item. In case of windowmenu role, we cannot change the role to window, so we need to check for windowmenu in the menu controller.

The default window menu regressed in #15930, when it switched from using window role to windowmenu.

Before
screen shot 2019-01-14 at 9 09 51 am
After
screen shot 2019-01-14 at 9 48 21 am

/cc @codebytere, @sindresorhus

Checklist

Release Notes

Notes: Fixed windowmenu role not showing the window list on macOS

@miniak miniak self-assigned this Jan 14, 2019

@miniak miniak requested a review from as a code owner Jan 14, 2019

@miniak miniak force-pushed the miniak/fix-windowmenu-role branch from 4c669ea to 5084c47 Jan 14, 2019

@miniak miniak requested a review from codebytere Jan 14, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

@codebytere should we backport some version of the windowmenu fix into release branches?

@miniak miniak requested a review from alexeykuzmin Jan 14, 2019

@codebytere

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

@miniak no, it hasn't been released yet.

@alexeykuzmin alexeykuzmin merged commit 52e2576 into master Jan 14, 2019

26 of 27 checks passed

electron-arm-testing Build #20190114.4 has failed
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm64-testing Build #20190114.1 succeeded
Details
electron-lint Build #20190114.2 succeeded
Details
electron-mas-testing Build #20190114.2 succeeded
Details
electron-osx-testing Build #20190114.2 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 14, 2019

Release Notes Persisted

Fixed windowmenu role not showing the window list on macOS

@alexeykuzmin alexeykuzmin deleted the miniak/fix-windowmenu-role branch Jan 14, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.