Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: respect the user's active app focus #16400
Apple recommends not setting this to true, and this behaviour is non-standard (not to mention annoying when someone is actively focused on another app, like writing) https://developer.apple.com/documentation/appkit/nsapplication/1428468-activateignoringotherapps?language=objc
Description of Change
Notes: Focus methods no longer steal focus when users are active on other apps
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Relevant Twitter thread: https://twitter.com/jnadeau/status/1084976858993573889
MarshallOfSound left a comment
One of these (the bundle mover) we definitely can't change.
The other two we probably can but I'd have to check the history of those impls. Tentative approval pending a check of the superview logic.