Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add `preload-error` event to `webContents` #16411

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
5 participants
@miniak
Copy link
Contributor

commented Jan 15, 2019

Description of Change

Currently there is no good way of telling if the preload script failed (such as unhandled exception)

/cc @nornagon, @MarshallOfSound

Checklist

Release Notes

Notes: Added preload-error event to webContents emitted when preload script fails (parse error, unhandled exception, etc.)

@miniak miniak requested review from nornagon and MarshallOfSound Jan 15, 2019

@miniak miniak requested review from as code owners Jan 15, 2019

@miniak miniak force-pushed the miniak/preload-error branch from 5ecbf8b to 1e6454d Jan 15, 2019

@miniak miniak self-assigned this Jan 16, 2019

@deepak1556
Copy link
Member

left a comment

LGTM

@alexeykuzmin alexeykuzmin merged commit 7d4a122 into master Jan 18, 2019

25 of 27 checks passed

electron-arm-testing Build #20190115.24 has failed
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm64-testing Build #20190115.17 succeeded
Details
electron-lint Build #20190115.27 succeeded
Details
electron-mas-testing Build #20190115.31 succeeded
Details
electron-osx-testing Build #20190115.26 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 18, 2019

Release Notes Persisted

Added preload-error event to webContents emitted when preload script fails (parse error, unhandled exception, etc.)

@alexeykuzmin alexeykuzmin deleted the miniak/preload-error branch Jan 18, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.