Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle IPC for promise-based methods #16433

Merged
merged 1 commit into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

commented Jan 17, 2019

Description of Change

Pulling this PR out of #16410, since zoomLevel and zoomFactor no longer need to be retrieved in an async manner. This PR takes into account async methods that return a promise as separate entities from those that simply take callbacks, and ensures that they are appropriately handled by ipc.

/cc @MarshallOfSound

Checklist

Release Notes

Notes: Fixed an issue with promise methods not resolving correctly over ipc in the renderer process.

@codebytere codebytere requested a review from as a code owner Jan 17, 2019

@codebytere codebytere merged commit 720197f into master Jan 17, 2019

27 of 29 checks passed

Backportable? - 3-1-x Backport Failed
Details
Backportable? - 4-0-x Backport Failed
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20190117.8 succeeded
Details
electron-arm64-testing Build #20190117.8 succeeded
Details
electron-lint Build #20190117.13 succeeded
Details
electron-mas-testing Build #20190117.12 succeeded
Details
electron-osx-testing Build #20190117.11 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 17, 2019

Release Notes Persisted

Fixed an issue with promise methods not resolving correctly over ipc in the renderer process.

@codebytere codebytere deleted the fix-ipc-passing-async branch Jan 17, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

codebytere added a commit that referenced this pull request Jan 31, 2019

@codebytere codebytere referenced this pull request Jan 31, 2019

Merged

fix: correctly handle IPC for promise-based methods #16654

6 of 6 tasks complete

codebytere added a commit that referenced this pull request Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.