Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure legacy callback functions work #16436

Merged
merged 3 commits into from Jan 17, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented Jan 17, 2019

Description of Change

Ensure legacy callback functions remain tested to prevent regressions as the promisification initiative continues.

cc @miniak

Checklist

Release Notes

Notes: Added legacy callback function tests to prevent regressions as the promisification initiative continues.

@codebytere codebytere requested a review from as a code owner Jan 17, 2019

codebytere added some commits Jan 17, 2019

@codebytere codebytere changed the title test: test legacy callback functions test: ensure legacy callback functions work Jan 17, 2019

@codebytere codebytere merged commit f105c84 into master Jan 17, 2019

27 checks passed

Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20190117.20 succeeded
Details
electron-arm64-testing Build #20190117.20 succeeded
Details
electron-lint Build #20190117.27 succeeded
Details
electron-mas-testing Build #20190117.29 succeeded
Details
electron-osx-testing Build #20190117.28 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 17, 2019

Release Notes Persisted

Added legacy callback function tests to prevent regressions as the promisification initiative continues.

@miniak miniak deleted the legacy-tests branch Jan 17, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

test: ensure legacy callback functions work (electron#16436)
* test: test legacy callback functions

* add TODO removal comments

* fix callback spec
@nornagon

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

this is a spec-only change, does it need release notes? If not, please replace the release-clerk comment with **No Release Notes**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.