New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: refactor text-to-speech to 4-0-x #16437

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@adill
Copy link
Contributor

adill commented Jan 17, 2019

Description of Change

Backport of #15024. Fixes TTS in Electron 4. Closes #16435.

/cc @brenca @nornagon

Checklist

Release Notes

Notes: Fixed speechSynthesis / text-to-speech.

@adill adill self-assigned this Jan 17, 2019

@adill adill requested review from nornagon and brenca Jan 17, 2019

@adill adill requested a review from electron/reviewers as a code owner Jan 17, 2019

@deepak1556
Copy link
Member

deepak1556 left a comment

LGTM, revert changes from #14657 to fix the builds failures on macOS. It had been reverted in master for a while now, we need extensions support for some chrome code.

refactor: move text-to-speech out of chromium_src (#15024)
* chore: add tts patch and buildflag, makes tts work again

* chore: add tts patch and buildflag, makes tts work again

* fix: make things compile

* build: add relevant tts files for linux

* fix: update patch and patch description, should now compile on mac

* build: move chrome specific sources under chromium_src:chrome target

* build: enable_extensions again

We are depending on them, check `//electron/chromium_src:chrome` target
for more info.

* fix: update tts.patch to receive notifications about browser context destruction

* fix: extend browser process from chrome layer

The global state g_browser_process is shared between //chrome
and //electron.

* spec: add basic speech synthesis test

* spec: skip speech tests on ci

* build: fix compilation on windows

@adill adill force-pushed the discordapp:backport-15024 branch from 870e89c to 3a6dec0 Jan 18, 2019

@adill

This comment has been minimized.

Copy link
Contributor Author

adill commented Jan 18, 2019

@deepak1556 I adjusted the patch to fix the build on mac. Looks good other than the usual flaky MAS tests.

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Jan 23, 2019

Merging as MAS failure is known flake.

@jkleinsc jkleinsc merged commit f747a66 into electron:4-0-x Jan 23, 2019

19 of 20 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be merged or rebased
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 23, 2019

Release Notes Persisted

Fixed speechSynthesis / text-to-speech.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment