New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use typescript for internal Electron JS code #16441

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
7 participants
@MarshallOfSound
Copy link
Member

MarshallOfSound commented Jan 18, 2019

This makes it possible for us to write Typescript for Electron's internals, it hooks up tsc inside GN before we generate electron.asar and default_app.asar and wires up generating Electron's type definitions into GN as well.

I haven't converted everything, just a few files from each ASAR to prove it works 馃憤

Notes: no-notes

cc @BinaryMuse @codebytere @ckerr

Note for reviewers: This is now based on top of #16718

@MarshallOfSound MarshallOfSound requested review from electron/docs as code owners Jan 18, 2019

Show resolved Hide resolved build/tsc.gni Outdated
Show resolved Hide resolved build/tsc.gni Outdated
Show resolved Hide resolved build/tsc.gni Outdated
Show resolved Hide resolved spec/fixtures/no-proprietary-codecs.js Outdated
Show resolved Hide resolved spec/static/main.js Outdated
Show resolved Hide resolved tools/cp-defs.js Outdated
Show resolved Hide resolved tools/js2asar.py Outdated
Show resolved Hide resolved tsconfig.default-app.json Outdated
Show resolved Hide resolved default_app/renderer.ts Outdated
Show resolved Hide resolved tsconfig.json Outdated
Show resolved Hide resolved .eslintrc.json Outdated
Show resolved Hide resolved BUILD.gn
Show resolved Hide resolved build/tsc.gni Outdated
Show resolved Hide resolved build/tsc.gni Outdated
Show resolved Hide resolved script/gen-filenames.js Outdated
Show resolved Hide resolved tsconfig.electron.json Outdated
Show resolved Hide resolved tsconfig.json Outdated

@MarshallOfSound MarshallOfSound force-pushed the internal-typescript branch 3 times, most recently from bf524dd to 4c0afad Feb 5, 2019

Show resolved Hide resolved build/tsc.gni Outdated

@MarshallOfSound MarshallOfSound force-pushed the internal-typescript branch from 4c0afad to 15affe3 Feb 6, 2019

@MarshallOfSound MarshallOfSound merged commit 26df999 into master Feb 6, 2019

9 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 6, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the internal-typescript branch Feb 6, 2019

@@ -149,9 +150,6 @@ app.setPath('userData', path.join(app.getPath('appData'), app.getName()))
app.setPath('userCache', path.join(app.getPath('cache'), app.getName()))
app.setAppPath(packagePath)

// Load the chrome devtools support.

This comment has been minimized.

@miniak

miniak Feb 7, 2019

Contributor

@MarshallOfSound seems like this was removed by mistake.

This comment has been minimized.

@MarshallOfSound

MarshallOfSound Feb 7, 2019

Author Member

Looks like a dodgy git rebase, I'll add it back

@dhewya

This comment has been minimized.

Copy link

dhewya commented Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment