Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added process.electron to get the electron version in the forked process #16450

Conversation

@SamvelRaja
Copy link
Contributor

commented Jan 18, 2019

Description of Change

This change addresses #9058.

Checklist

Release Notes

Notes: added process.versions.electron to get the electron version in the forked process

@SamvelRaja SamvelRaja requested a review from as a code owner Jan 18, 2019

@miniak
Copy link
Contributor

left a comment

we should expose it as process.versions.electron instead to keep the same API
also need to add tests (btw you should keep the checklist in the description from the template)

@SamvelRaja

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2019

@miniak
Updated the PR based on your comments.
I am not sure on the crash reporter tests failing in CI.
Also, I not sure on whether this change needs a doc update, as i couldn't find a doc related to it.

@SamvelRaja SamvelRaja force-pushed the SamvelRaja:feature/add-electron-version-to-child-process branch from b0012bb to 9362bc4 Jan 19, 2019

@SamvelRaja

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2019

@miniak Is anything else I need to look for? The CI seems to fail for different reason 🤔

@miniak

miniak approved these changes Jan 27, 2019

@SamvelRaja

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

Can someone merge this PR?

@codebytere codebytere merged commit 8af532b into electron:master Jan 30, 2019

20 of 23 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
electron-lint Build #20190119.2 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 30, 2019

Release Notes Persisted

added process.versions.electron to get the electron version in the forked process

@SamvelRaja

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2019

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.