Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify cookies api #16464

Merged
merged 9 commits into from Jan 25, 2019

Conversation

@ckerr
Copy link
Member

commented Jan 19, 2019

Description of Change

Promisifies the cookie API.

CC @codebytere

Checklist

Release Notes

Notes: Added Promise support for the Cookies API.

@ckerr ckerr requested review from as code owners Jan 19, 2019

@ckerr ckerr referenced this pull request Jan 19, 2019

Closed

[wip] feat: promisify cookies API #16068

7 of 11 tasks complete

@codebytere codebytere changed the title Promisify cookies feat: promisify cookies api Jan 20, 2019

Show resolved Hide resolved docs/api/cookies.md Outdated
Show resolved Hide resolved docs/api/cookies.md Outdated
Show resolved Hide resolved docs/api/cookies.md Outdated
Show resolved Hide resolved docs/api/cookies.md Outdated

@ckerr ckerr force-pushed the promisify-cookie branch from 36e8bc6 to da6c405 Jan 24, 2019

@ckerr

This comment has been minimized.

Copy link
Member Author

commented Jan 25, 2019

@codebytere
Copy link
Member

left a comment

⭐️

@ckerr ckerr merged commit 8396a2d into master Jan 25, 2019

23 of 27 checks passed

electron-arm-testing Build #20190125.1 has failed
Details
electron-arm64-testing Build #20190125.1 has failed
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-lint Build #20190125.1 succeeded
Details
electron-mas-testing Build #20190125.1 succeeded
Details
electron-osx-testing Build #20190125.1 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 25, 2019

Release Notes Persisted

Added Promise support for the Cookies API.

@ckerr ckerr deleted the promisify-cookie branch Jan 25, 2019

codebytere added a commit that referenced this pull request Feb 2, 2019

feat: promisify cookies api (#16464)
* feat: promisify the Cookie API

* chore: update specs to test promisified cookies

* chore: add deprecate wrapper for cookie callback API

* docs: update docs to cookie promise changes

* chore: remove redundant namespace use

* docs: improve cookie example

* docs: restore docs for cookie callback API

* chore: restore cookie callback tests

* fix: syntax of cookie promise return types

@codebytere codebytere referenced this pull request Feb 2, 2019

Merged

feat: promisify cookies api #16702

6 of 6 tasks complete

codebytere added a commit that referenced this pull request Feb 3, 2019

feat: promisify cookies api (#16702)
* feat: promisify cookies api (#16464)

* feat: promisify the Cookie API

* chore: update specs to test promisified cookies

* chore: add deprecate wrapper for cookie callback API

* docs: update docs to cookie promise changes

* chore: remove redundant namespace use

* docs: improve cookie example

* docs: restore docs for cookie callback API

* chore: restore cookie callback tests

* fix: syntax of cookie promise return types

* fix: use new promisify helper

@sofianguy sofianguy added this to 5.0.0-beta.2 in 5.0.x Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.