Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make ipc-message and ipc-message-sync events public #16468

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
6 participants
@miniak
Copy link
Contributor

commented Jan 20, 2019

Description of Change

  • Allows handling IPC messages for particular webContents.
  • Both ipc-message and ipc-message-sync on webContents are refactored to make the arguments easier to handle.

/cc @MarshallOfSound, @nornagon

Checklist

Release Notes

Notes: Added ipc-message and ipc-message-sync events to webContents.

@miniak miniak requested review from as code owners Jan 20, 2019

@miniak miniak changed the title feat: make `ipc-message` and `ipc-message-sync` events public feat: make ipc-message and ipc-message-sync events public Jan 20, 2019

@miniak miniak requested review from MarshallOfSound and nornagon Jan 20, 2019

@miniak miniak force-pushed the miniak/ipc-message branch from 0c43c6e to d29e22b Jan 20, 2019

@miniak miniak self-assigned this Jan 20, 2019

@miniak miniak force-pushed the miniak/ipc-message branch 2 times, most recently from fe38ad6 to e5b6474 Jan 20, 2019

@MarshallOfSound
Copy link
Member

left a comment

Can you remove all refactors of the internal implementation of IPC. The only things that need to happen this PR

  • Publicly document the events
  • Change the signiture of ipc-message* events to be event, channel, ...args instead of event, [channel, args]

@miniak miniak force-pushed the miniak/ipc-message branch 3 times, most recently from f19fda8 to 6828ed5 Jan 21, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2019

@miniak miniak force-pushed the miniak/ipc-message branch from 6828ed5 to 5b4e391 Jan 21, 2019

@zcbenz

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

The CI is failing on 2 tests:

chromium feature navigator.serviceWorker should register for file scheme - should register for file scheme
chromium feature window.opener is null for main window - is null for main window

They don't seem to be flaky as they are failing on all platforms, though I'm not sure why this change would lead to the failures.

@miniak miniak force-pushed the miniak/ipc-message branch from 5b4e391 to c7dbed3 Jan 22, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2019

@zcbenz fixed

@zcbenz

zcbenz approved these changes Jan 22, 2019

@miniak miniak force-pushed the miniak/ipc-message branch from c7dbed3 to 9afe998 Jan 22, 2019

@ppontes
Copy link
Member

left a comment

Nice!

@BinaryMuse BinaryMuse merged commit 6cba2c5 into master Jan 22, 2019

24 of 25 checks passed

Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-lint Build #20190122.8 succeeded
Details
electron-mas-testing Build #20190122.14 succeeded
Details
electron-osx-testing Build #20190122.13 succeeded
Details
release-notes Release notes found

@BinaryMuse BinaryMuse deleted the miniak/ipc-message branch Jan 22, 2019

@release-clerk

This comment has been minimized.

Copy link

commented Jan 22, 2019

Release Notes Persisted

Added ipc-message and ipc-message-sync events to webContents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.