Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: <webview> not working with contextIsolation + sandbox #16469

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
4 participants
@miniak
Copy link
Contributor

commented Jan 20, 2019

Description of Change

  • The isolated_renderer/init.js script was not being injected into the main world context of sandboxed renderers
  • The code for forwarding the focus event was missing in lib/sandboxed_renderer/init.js.

/cc @nornagon @MarshallOfSound

Checklist

Release Notes

Notes: Fixed <webview> not working with contextIsolation + sandbox.
Fixed focus event not emitted when <webview> is sandboxed.

@miniak miniak requested a review from as a code owner Jan 20, 2019

@miniak miniak self-assigned this Jan 20, 2019

@miniak miniak force-pushed the miniak/webview-focus-sandbox branch 4 times, most recently from 67044a4 to 9cf35a1 Jan 20, 2019

@miniak miniak changed the title fix: focus event not emitted when <webview> is sandboxed fix: <webview> not working with contextIsolation + sandbox Jan 20, 2019

@miniak miniak force-pushed the miniak/webview-focus-sandbox branch from 9cf35a1 to df7c47a Jan 20, 2019

@miniak miniak force-pushed the miniak/webview-focus-sandbox branch from df7c47a to af5869f Jan 20, 2019

@zcbenz

zcbenz approved these changes Jan 21, 2019

Copy link
Member

left a comment

👍

@zcbenz zcbenz merged commit b965e54 into master Jan 22, 2019

27 of 29 checks passed

Backportable? - 3-1-x Cancelled
Details
Backportable? - 4-0-x Cancelled
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20190120.12 succeeded
Details
electron-arm64-testing Build #20190120.12 succeeded
Details
electron-lint Build #20190120.19 succeeded
Details
electron-mas-testing Build #20190120.19 succeeded
Details
electron-osx-testing Build #20190120.19 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 22, 2019

Release Notes Persisted

Fixed <webview> not working with contextIsolation + sandbox.

@zcbenz zcbenz deleted the miniak/webview-focus-sandbox branch Jan 22, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.