Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: TouchBar API example #16482

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@mattleff
Copy link
Contributor

commented Jan 22, 2019

Description of Change

Corrected TouchBar API example per code:

let { items, escapeItem } = options
This API seems to have changed with #15650.

Checklist

Release Notes

Notes: Improved TouchBar API documentation

@mattleff mattleff requested a review from as a code owner Jan 22, 2019

@welcome

This comment has been minimized.

Copy link

commented Jan 22, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

Good catch, thanks 👍

@MarshallOfSound MarshallOfSound merged commit a9ac75c into electron:master Jan 22, 2019

17 of 21 checks passed

appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
ci/circleci: mas-testing CircleCI is running your tests
Details
ci/circleci: osx-testing CircleCI is running your tests
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-lint Build #20190122.2 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 22, 2019

Release Notes Persisted

Improved TouchBar API documentation

@welcome

This comment has been minimized.

Copy link

commented Jan 22, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@mattleff mattleff deleted the mattleff:patch-1 branch Jan 22, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.