New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix web-request.md listener signatures in electron.d.ts (backport: 4-0-x) #16487

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
4 participants
@trop
Copy link
Contributor

trop bot commented Jan 22, 2019

Backport of #16485

See that PR for details.

Notes: Fixed onBeforeSendHeaders / onSendHeaders listener signatures in electron.d.ts.

@trop trop bot requested a review from electron/docs as a code owner Jan 22, 2019

@trop trop bot referenced this pull request Jan 22, 2019

Merged

docs: fix web-request.md listener signatures in electron.d.ts #16485

5 of 5 tasks complete

@trop trop bot added 4-0-x backport labels Jan 22, 2019

@MarshallOfSound MarshallOfSound merged commit 7c55db2 into electron:4-0-x Jan 22, 2019

19 of 20 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 22, 2019

Release Notes Persisted

Fixed onBeforeSendHeaders / onSendHeaders listener signatures in electron.d.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment