New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable and update osr #16517

Merged
merged 4 commits into from Jan 30, 2019

Conversation

4 participants
@codebytere
Copy link
Member

codebytere commented Jan 23, 2019

Description of Change

Closes #16502.

Re-enable osr following last two Chromium upgrades.

cc @brenca

Checklist

Release Notes

Notes: Fixed and re-enabled osr after it was turned off following updates to Chromium 71/72.

brenca and others added some commits Jan 23, 2019

@codebytere codebytere requested a review from electron/reviewers as a code owner Jan 23, 2019

@brenca brenca changed the title fix: enable and update osr [WIP] fix: enable and update osr Jan 24, 2019

@brenca brenca changed the title [WIP] fix: enable and update osr fix: enable and update osr Jan 28, 2019

@brenca

brenca approved these changes Jan 28, 2019

@codebytere codebytere merged commit c7677b2 into master Jan 30, 2019

19 of 20 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 30, 2019

Release Notes Persisted

Fixed and re-enabled osr after it was turned off following updates to Chromium 71/72.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 30, 2019

I have automatically backported this PR to "5-0-x", please check out #16616

@trop trop bot added in-flight/5-0-x and removed target/5-0-x labels Jan 30, 2019

@codebytere codebytere deleted the brenca/enable-osr branch Jan 30, 2019

@trop trop bot added merged/5-0-x and removed in-flight/5-0-x labels Jan 30, 2019

@sofianguy sofianguy added this to 5.0.0-beta.2 in 5.0.x Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment