Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: enable and update osr #16517
Conversation
brenca
and others
added some commits
Jan 23, 2019
codebytere
requested a review
from electron/reviewers
as a
code owner
Jan 23, 2019
brenca
changed the title
fix: enable and update osr
[WIP] fix: enable and update osr
Jan 24, 2019
brenca
changed the title
[WIP] fix: enable and update osr
fix: enable and update osr
Jan 28, 2019
brenca
approved these changes
Jan 28, 2019
alexeykuzmin
approved these changes
Jan 30, 2019
codebytere
added
the
target/5-0-x
label
Jan 30, 2019
codebytere
merged commit c7677b2
into
master
Jan 30, 2019
19 of 20 checks passed
appveyor: win-ia32-testing
AppVeyor build failed
Details
Absolute Zero
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-debug
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-debug
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests
Your tests passed on CircleCI!
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Jan 30, 2019
|
Release Notes Persisted
|
trop
bot
referenced this pull request
Jan 30, 2019
Merged
fix: enable and update osr (backport: 5-0-x) #16616
This comment has been minimized.
This comment has been minimized.
|
I have automatically backported this PR to "5-0-x", please check out #16616 |
trop
bot
added
in-flight/5-0-x
and removed
target/5-0-x
labels
Jan 30, 2019
codebytere
deleted the
brenca/enable-osr
branch
Jan 30, 2019
sofianguy
added
the
app-feedback-program
label
Jan 30, 2019
trop
bot
added
merged/5-0-x
and removed
in-flight/5-0-x
labels
Jan 30, 2019
sofianguy
added this to 5.0.0-beta.2
in 5.0.x
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
codebytere commentedJan 23, 2019
•
edited
Description of Change
Closes #16502.
Re-enable osr following last two Chromium upgrades.
cc @brenca
Checklist
npm testpassesRelease Notes
Notes: Fixed and re-enabled osr after it was turned off following updates to Chromium 71/72.