Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly destroy spellcheck client #16525

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@nitsakh
Copy link
Contributor

commented Jan 24, 2019

Description of Change

Backport of #16448.

Checklist

Release Notes

Notes: Fixed memory leak caused by webFrame.setSpellCheckProvider.

@nitsakh nitsakh requested a review from as a code owner Jan 24, 2019

@deepak1556

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

Can we re-run the ci build for electron-mas-testing, the test failure is a little concerning. Although this patch does pass on master.

@nitsakh any idea what might cause it to flake ?

@codebytere codebytere changed the title Fix spell leak 5 0 fix: correctly destroy spellcheck client Jan 24, 2019

@nitsakh

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

Not sure why that's failing. This change shouldn't have affected the spellcheck implementation.

@codebytere

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

@deepak1556 the failure passes on rerun, we should be good to go here!

@codebytere codebytere merged commit ae85864 into 5-0-x Jan 29, 2019

23 of 26 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
electron-arm-testing Build #20190124.4 has failed
Details
electron-arm64-testing Build #20190124.4 has failed
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-mas-testing Build #20190128.23 succeeded
Details
electron-osx-testing Build #20190124.8 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 30, 2019

Release Notes Persisted

Fixed memory leak caused by webFrame.setSpellCheckProvider.

@codebytere codebytere deleted the fix-spell-leak-5-0 branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.