New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix extra closing parenthesis #16528

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
2 participants
@MAKIO135
Copy link

MAKIO135 commented Jan 24, 2019

Description of Change

There was an extra closing parenthesis in the example of creating a menu dynamically in a web page https://electronjs.org/docs/api/menu#render-process

Checklist

  • relevant documentation is changed or added

Release Notes

Notes: no-notes

@MAKIO135 MAKIO135 requested a review from electron/docs as a code owner Jan 24, 2019

@welcome

This comment has been minimized.

Copy link

welcome bot commented Jan 24, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@MAKIO135 MAKIO135 changed the title fix extra closing parenthesis docs: fix extra closing parenthesis Jan 24, 2019

@jkleinsc
Copy link
Contributor

jkleinsc left a comment

@MAKIO135 nice catch! Thanks for the PR!

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Jan 25, 2019

Merging as CI failure unrelated to doc change.

@jkleinsc jkleinsc merged commit fb8bde0 into electron:4-0-x Jan 25, 2019

19 of 20 checks passed

ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 25, 2019

No Release Notes

@welcome

This comment has been minimized.

Copy link

welcome bot commented Jan 25, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment