New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: registerStreamProtocol callback with large chunks (backport: 4-0-x) #16540

Merged
merged 2 commits into from Jan 25, 2019

Conversation

Projects
None yet
2 participants
@nornagon
Copy link
Contributor

nornagon commented Jan 24, 2019

Description of Change

Backports #16532 to 4-0-x. See that PR for details.

Notes: Fixed an issue where data streamed from registerStreamProtocol could be truncated before completion.

@nornagon nornagon requested a review from electron/reviewers as a code owner Jan 24, 2019

@trop trop bot referenced this pull request Jan 24, 2019

Merged

fix: registerStreamProtocol callback with large chunks #16532

5 of 5 tasks complete

@nornagon nornagon merged commit cf079f6 into 4-0-x Jan 25, 2019

19 of 20 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 25, 2019

Release Notes Persisted

Fixed an issue where data streamed from registerStreamProtocol could be truncated before completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment