Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cancel is optional in OnHeadersReceivedResponse (backport: 5-0-x) #16549

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

commented Jan 25, 2019

Backport of #16506

See that PR for details.

Notes: Documented the cancel property in OnHeadersReceivedResponse as optional.

@trop trop bot requested a review from as a code owner Jan 25, 2019

@trop trop bot referenced this pull request Jan 25, 2019

Merged

docs: cancel is optional in OnHeadersReceivedResponse #16506

5 of 5 tasks complete

@trop trop bot added 5-0-x backport labels Jan 25, 2019

@codebytere codebytere merged commit 7a8548d into electron:5-0-x Jan 25, 2019

18 of 22 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 25, 2019

Release Notes Persisted

Documented the cancel property in OnHeadersReceivedResponse as optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.