New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport a memory leak fix in webrtc #16555

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
3 participants
@nornagon
Copy link
Contributor

nornagon commented Jan 25, 2019

Description of Change

Fixes #16542

Checklist

Release Notes

Notes: Fixed a memory leak in desktopCapturer.getSources('screen') on macOS.

@nornagon nornagon requested a review from alexeykuzmin Jan 25, 2019

@nornagon nornagon requested a review from electron/reviewers as a code owner Jan 25, 2019

@nornagon

This comment has been minimized.

Copy link
Contributor Author

nornagon commented Jan 28, 2019

win test failures look like flake, merging

@nornagon nornagon merged commit 939e65d into 4-0-x Jan 28, 2019

18 of 20 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
appveyor: win-x64-testing AppVeyor build failed
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 28, 2019

Release Notes Persisted

Fixed a memory leak in desktopCapturer.getSources('screen') on macOS.

@nornagon nornagon deleted the backport-webrtc-leak-fix branch Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment