Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify contentTracing.getCategories() #16583

Merged
merged 2 commits into from Jan 30, 2019

Conversation

@codebytere
Copy link
Member

commented Jan 29, 2019

Description of Change

Promisify contentTracing.getCategories().

cc @ckerr @deepak1556

Checklist

Release Notes

Notes: Converted contentTracing.getCategories() to return a promise instead taking a callback.

@codebytere codebytere requested review from as code owners Jan 29, 2019

@codebytere codebytere force-pushed the promisify-getcategories branch from c3e4e1d to d732d05 Jan 29, 2019

@codebytere codebytere force-pushed the promisify-getcategories branch from d732d05 to ef9cc29 Jan 29, 2019

@miniak

miniak approved these changes Jan 30, 2019

@codebytere codebytere force-pushed the promisify-getcategories branch from bf940c0 to 25fa087 Jan 30, 2019

@ckerr

ckerr approved these changes Jan 30, 2019

@codebytere codebytere merged commit 641b47f into master Jan 30, 2019

22 of 26 checks passed

electron-arm-testing Build #20190130.28 has failed
Details
electron-arm64-testing Build #20190130.29 has failed
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-lint Build #20190130.22 succeeded
Details
electron-mas-testing Build #20190130.29 succeeded
Details
electron-osx-testing Build #20190130.29 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 30, 2019

Release Notes Persisted

Converted contentTracing.getCategories() to return a promise instead taking a callback.

@codebytere codebytere deleted the promisify-getcategories branch Jan 30, 2019

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Jan 30, 2019

/trop run backport-to 5-0-x

@trop

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

codebytere added a commit that referenced this pull request Jan 30, 2019

feat: promisify contentTracing.getCategories() (#16583)
* feat: promisify contentTracing.getCategories()

* deprecate contentTracing/getCategories
@codebytere codebytere referenced this pull request Jan 30, 2019
6 of 6 tasks complete

codebytere added a commit that referenced this pull request Feb 1, 2019

feat: promisify contentTracing.getCategories() (#16583)
* feat: promisify contentTracing.getCategories()

* deprecate contentTracing/getCategories

codebytere added a commit that referenced this pull request Feb 1, 2019

feat: promisify contentTracing.getCategories() (#16583)
* feat: promisify contentTracing.getCategories()

* deprecate contentTracing/getCategories

codebytere added a commit that referenced this pull request Feb 1, 2019

feat: promisify contentTracing.getCategories() (#16583)
* feat: promisify contentTracing.getCategories()

* deprecate contentTracing/getCategories

codebytere added a commit that referenced this pull request Feb 2, 2019

feat: promisify contentTracing.getCategories() (#16583) (#16624)
* feat: promisify contentTracing.getCategories()

* deprecate contentTracing/getCategories

@sofianguy sofianguy added this to 5.0.0-beta.2 in 5.0.x Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.