Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add process.getSystemVersion() #16599

Merged
merged 1 commit into from Feb 18, 2019

Conversation

@miniak
Copy link
Contributor

commented Jan 29, 2019

Description of Change

  • available in sandboxed renderers
  • returns the actual operating system version instead of kernel version on macOS

Checklist

Release Notes

Notes: Added process.getSystemVersion(), which is available in sandboxed renderers and returns the actual operating system version instead of kernel version on macOS.

@miniak miniak requested review from as code owners Jan 29, 2019

@miniak miniak force-pushed the miniak/get-system-version branch from 739ab6f to 7a1a614 Jan 29, 2019

@miniak miniak self-assigned this Jan 29, 2019

@miniak miniak added the target/5-0-x label Jan 29, 2019

@miniak miniak force-pushed the miniak/get-system-version branch from 7a1a614 to d211718 Jan 29, 2019

@ckerr ckerr added the semver/minor label Jan 30, 2019

@ckerr

ckerr approved these changes Jan 30, 2019

Copy link
Member

left a comment

As a procedural matter it might be good to put this up for an emoji-vote on #pineapple since it adds a new feature to a stability branch.

That said, I'm 👍 on this PR

@ckerr
Copy link
Member

left a comment

Hmm actually my last review sends a mixed message of approving + asking for further work.

So I'm giving a "Request changes" here solely as a procedural step of getting team feedback on adding a semver/minor feature to 5-0-x

Show resolved Hide resolved docs/api/process.md

@miniak miniak removed the target/5-0-x label Feb 4, 2019

@miniak miniak force-pushed the miniak/get-system-version branch from d211718 to 4e869b4 Feb 14, 2019

@miniak miniak force-pushed the miniak/get-system-version branch from 4e869b4 to 32bbcf2 Feb 14, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

@ckerr, @nornagon I've removed the target/5-0-x label + added the example values. Can you please approve?

@jkleinsc jkleinsc requested a review from ckerr Feb 15, 2019

@ckerr ckerr dismissed their stale review Feb 18, 2019

if we're only targeting master, the question of semver/minor is moot

@ckerr

ckerr approved these changes Feb 18, 2019

@ckerr ckerr merged commit a04d9ef into master Feb 18, 2019

13 of 15 checks passed

electron-arm-testing Build #20190214.43 has failed
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190214.43 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 18, 2019

Release Notes Persisted

Added process.getSystemVersion(), which is available in sandboxed renderers and returns the actual operating system version instead of kernel version on macOS.

@ckerr ckerr deleted the miniak/get-system-version branch Feb 18, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

/trop run backport-to 5-0-x

@trop

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

I have automatically backported this PR to "5-0-x", please check out #17141

@trop trop bot added the in-flight/5-0-x label Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.