New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run Windows Electron tests first to show those failures first #16610

Merged
merged 3 commits into from Jan 31, 2019

Conversation

Projects
None yet
3 participants
@jkleinsc
Copy link
Contributor

jkleinsc commented Jan 30, 2019

The windows 32-bit CI build is stalling on the Electron tests, so this PR reorganizes our CI tests to run electron tests before verifying ffmpeg and mksnapshot. Also, this PR enables logging on Appveyor (Windows) CI to give better insight into failing tests.

Description of Change

Checklist

Release Notes

Notes: no-notes

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Jan 30, 2019

@ckerr

ckerr approved these changes Jan 30, 2019

@jkleinsc jkleinsc force-pushed the fix-32bit-windows branch from 3766bf6 to 5e24e57 Jan 31, 2019

@jkleinsc jkleinsc merged commit d71f1fb into master Jan 31, 2019

20 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 31, 2019

Release Notes Persisted

no-notes
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 31, 2019

I have automatically backported this PR to "5-0-x", please check out #16655

@trop trop bot added in-flight/5-0-x and removed target/5-0-x labels Jan 31, 2019

@alexeykuzmin alexeykuzmin deleted the fix-32bit-windows branch Jan 31, 2019

@trop trop bot added merged/5-0-x and removed in-flight/5-0-x labels Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment