Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add API to inspect a Shared Worker #16615

Merged
merged 1 commit into from Feb 1, 2019

Conversation

@michtsu
Copy link
Contributor

commented Jan 30, 2019

Description of Change

This change adds a new inspectSharedWorker() API to enable opening devtools for a shared worker.

Checklist

Release Notes

notes: Added new inspectSharedWorker() API to enable opening devtools for a shared worker.

@michtsu michtsu requested review from as code owners Jan 30, 2019

@welcome

This comment has been minimized.

Copy link

commented Jan 30, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@michtsu michtsu changed the title devtools: Add API to inspect shared worker. feat: Add API to inspect shared worker. Jan 30, 2019

@alexeykuzmin alexeykuzmin changed the title feat: Add API to inspect shared worker. feat: Add API to inspect a Shared Worker Jan 30, 2019

@ckerr ckerr added the semver/minor label Jan 30, 2019

@ckerr

ckerr approved these changes Jan 30, 2019

Copy link
Member

left a comment

LGTM

@miniak

miniak approved these changes Jan 30, 2019

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Closing and reopening to trigger new Archeologist

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

@michtsu Could you please rebase your branch onto the latest master once #16610 is merged?

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

@michtsu, #16610 was merged a few hours ago.

@michtsu michtsu force-pushed the michtsu:michtsu/debugSharedWorker branch from 206957f to 770bb4c Jan 31, 2019

@jkleinsc jkleinsc closed this Feb 1, 2019

@jkleinsc jkleinsc reopened this Feb 1, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

For some reason, CircleCI didn't trigger for this PR. I pulled down the changes into a branch and triggered CircleCI here: https://github.com/electron/electron/runs/57810949

@michtsu

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2019

For some reason, CircleCI didn't trigger for this PR. I pulled down the changes into a branch and triggered CircleCI here: https://github.com/electron/electron/runs/57810949

Looks like CI is passing now - @jkleinsc can you merge it? Thanks!

@codebytere codebytere merged commit 392458b into electron:master Feb 1, 2019

8 of 9 checks passed

Artifact Comparison Changes Detected
Details
Absolute Zero
Backportable? - 5-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
electron-lint Build #20190201.6 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 1, 2019

Release Notes Persisted

Added new inspectSharedWorker() API to enable opening devtools for a shared worker.

@welcome

This comment has been minimized.

Copy link

commented Feb 1, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@trop

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

I have automatically backported this PR to "5-0-x", please check out #16681

@trop trop bot added in-flight/5-0-x and removed target/5-0-x labels Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.