New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose aes-cfb ciphers from boringssl (backport: 4-0-x) #16617

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Jan 30, 2019

Backport of #16573

See that PR for details.

Notes: Restored support for AES-CFB cipher, which was lost when switching from OpenSSL to BoringSSL.

@trop trop bot requested a review from electron/reviewers as a code owner Jan 30, 2019

@trop trop bot referenced this pull request Jan 30, 2019

Merged

fix: expose aes-cfb ciphers from boringssl #16573

4 of 4 tasks complete

@trop trop bot added 4-0-x backport labels Jan 30, 2019

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Jan 30, 2019

AssertionError: value should eventually become the pasted value: expected '' to equal 'test value'

Consistent failure on windows, maybe unrelated but probably slipped through in another PR?

@codebytere codebytere merged commit 28c19da into electron:4-0-x Jan 31, 2019

16 of 20 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
appveyor: win-x64-testing-pr AppVeyor build failed
Details
ci/circleci: linux-ia32-testing-tests Your tests failed on CircleCI
Details
ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 31, 2019

Release Notes Persisted

Restored support for AES-CFB cipher, which was lost when switching from OpenSSL to BoringSSL.

@Silbad Silbad referenced this pull request Feb 2, 2019

Open

Unknown cipher #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment