Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify contentTracing.getCategories() #16624

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

commented Jan 30, 2019

Description of Change

Backport of #16583.

cc @ckerr

Checklist

Release Notes

Notes: Converted contentTracing.getCategories() to return a promise instead taking a callback.

@codebytere codebytere requested review from as code owners Jan 30, 2019

@codebytere codebytere changed the base branch from master to 5-0-x Jan 30, 2019

@codebytere codebytere changed the title Getcategories bp feat: promisify contentTracing.getCategories() Jan 30, 2019

@ckerr

ckerr approved these changes Feb 1, 2019

@codebytere codebytere force-pushed the getcategories-bp branch from 8f22555 to a6fd447 Feb 1, 2019

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Feb 1, 2019

This shouldn't be merged until it's rebased on #16643

@codebytere codebytere force-pushed the getcategories-bp branch from a6fd447 to 9b0afd6 Feb 1, 2019

feat: promisify contentTracing.getCategories() (#16583)
* feat: promisify contentTracing.getCategories()

* deprecate contentTracing/getCategories

@codebytere codebytere force-pushed the getcategories-bp branch from 9b0afd6 to 7c83937 Feb 1, 2019

@codebytere codebytere merged commit 6d76da5 into 5-0-x Feb 2, 2019

14 of 15 checks passed

Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190201.35 succeeded
Details
electron-arm64-testing Build #20190201.34 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 2, 2019

Release Notes Persisted

Converted contentTracing.getCategories() to return a promise instead taking a callback.

@codebytere codebytere deleted the getcategories-bp branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.