Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move webFrame scheme privilege methods to main process #16625

Merged
merged 2 commits into from Jan 30, 2019

Conversation

Projects
None yet
3 participants
@nitsakh
Copy link
Contributor

commented Jan 30, 2019

Description of Change

Backport of #16416 and #16601.

BREAKING CHANGE

Checklist

Release Notes

Notes: Moved webFrame custom scheme APIs to browser process under protocol

nitsakh added some commits Jan 29, 2019

feat: move webFrame scheme privilege methods to main process (#16416)
* chore: deprecate webFrame.registerURLSchemeAsPrivileged

* Add register schemes protocol api

* update branch to enable browser process API

* Revert deprecation changes

* Fetch API support

* Updated api to take an array, still working on tests

* Update tests

* Remove web frame API

* Minor changes

* update scheme registrations on browser and renderer process

* fix: enable ses.getBlobData spec

* Update breaking changes doc
fix: update docs for protocol API (#16601)
* fix: update docs for protocol API

* upddate source for new attribute name

* update electron-typescript-definitions package

@nitsakh nitsakh requested review from as code owners Jan 30, 2019

@trop trop bot referenced this pull request Jan 30, 2019

Merged

fix: update docs for protocol API #16601

6 of 6 tasks complete

@nitsakh nitsakh changed the base branch from master to 5-0-x Jan 30, 2019

@nitsakh nitsakh changed the title Schemes api 5 chore: Move webFrame scheme privilege methods to main process Jan 30, 2019

@MarshallOfSound MarshallOfSound merged commit d6612d2 into 5-0-x Jan 30, 2019

17 of 25 checks passed

appveyor: win-ia32-testing-pr AppVeyor was unable to build non-mergeable pull request
Details
appveyor: win-x64-testing-pr AppVeyor was unable to build non-mergeable pull request
Details
electron-arm-testing Build #20190130.51 has failed
Details
electron-arm64-testing Build #20190130.50 has failed
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-debug Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-mas-testing Build #20190130.56 succeeded
Details
electron-osx-testing Build #20190130.56 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 30, 2019

Release Notes Persisted

Moved webFrame custom scheme APIs to browser process under protocol

@MarshallOfSound MarshallOfSound deleted the schemes-api-5 branch Jan 30, 2019

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

This is a breaking change yes? I've added BREAKING CHANGE to the PR description, remove it if I'm wrong.

samuelthomas2774 added a commit to samuelthomas2774/BetterDiscordApp that referenced this pull request Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.