Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump chromium to 69.0.3497.128 (4-0-x) #16636

Merged
merged 1 commit into from Feb 26, 2019

Conversation

Projects
None yet
5 participants
@roller-bot
Copy link
Contributor

roller-bot commented Jan 31, 2019

Updating Chromium to 69.0.3497.128. Changes since the last roll:

  • c6a08e5 Publish DEPS for 69.0.3497.128
  • cdec0ad Incrementing VERSION to 69.0.3497.128
  • e7484d0 Incrementing VERSION to 69.0.3497.127
  • 1d5445a Incrementing VERSION to 69.0.3497.126
  • b87a355 Incrementing VERSION to 69.0.3497.125
  • 1e7fba9 Incrementing VERSION to 69.0.3497.124
  • 82877b1 Incrementing VERSION to 69.0.3497.123
  • 3422f2f Incrementing VERSION to 69.0.3497.122
  • 254dc42 Incrementing VERSION to 69.0.3497.121
  • 82a246f Incrementing VERSION to 69.0.3497.120
  • 1e03e8b Incrementing VERSION to 69.0.3497.119
  • c9c6d8e Fix crash when closing USB connection after Mojo connection error
  • 87ab386 Incrementing VERSION to 69.0.3497.118
  • fb39d4e Restrict conditions to perform Tether network scans.
  • ff8aedb Incrementing VERSION to 69.0.3497.117
  • ca3fdae Incrementing VERSION to 69.0.3497.116
  • fe46bf4 Incrementing VERSION to 69.0.3497.115
  • 7ce7d05 Revert "cros: Fix crash when removing secondary user with public session displayed."
  • e7f837e Incrementing VERSION to 69.0.3497.114
  • d409bdb cros: Fix crash when removing secondary user with public session displayed.
  • 813bf9b Incrementing VERSION to 69.0.3497.113
  • 797f1d8 Incrementing VERSION to 69.0.3497.112
  • 921eeec Revert "[PE] Fix paint offset of floating object under display:-webkit-box"
  • abf64e2 [PE] Fix paint offset of floating object under display:-webkit-box
  • 65fabe6 [Merge to M-69] Fix a tablet mode crash when navigating to interstitial page
  • fb6a494 Incrementing VERSION to 69.0.3497.111
  • 77deb72 Incrementing VERSION to 69.0.3497.110
  • e7d0c07 Incrementing VERSION to 69.0.3497.109
  • 2604aeb Fix access violation in drive sync engine.
  • f75a54a Incrementing VERSION to 69.0.3497.108
  • d157327 Send lcd density to mini container
  • a7d0f38 DefaultScaleFactor retriever
  • 28d0399 Incrementing VERSION to 69.0.3497.107
  • 7ea35bc Roll src/third_party/cros_system_api/ e0781f23b..ee1765f00 (9 commits)

Notes: Updated Chromium to 69.0.3497.128.

@roller-bot roller-bot requested a review from as a code owner Jan 31, 2019

@nornagon
Copy link
Contributor

nornagon left a comment

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Jan 31, 2019

@nornagon This is a lot of Incrementing VERSION and not a lot of changes, is the bot correctly logging commits?

@nornagon

This comment has been minimized.

Copy link
Contributor

nornagon commented Jan 31, 2019

@deepak1556
Copy link
Member

deepak1556 left a comment

Is the windows ci failure a flake ?

@nornagon nornagon merged commit ffd8c36 into electron:4-0-x Feb 26, 2019

20 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 26, 2019

Release Notes Persisted

Updated Chromium to 69.0.3497.128.

@bpasero

This comment has been minimized.

Copy link
Contributor

bpasero commented Mar 4, 2019

@deepak1556 @MarshallOfSound fyi when I start Electron 4.0.6 in fiddle I still see an older Chrome version string printed:

image

@nornagon

This comment has been minimized.

Copy link
Contributor

nornagon commented Mar 4, 2019

ahh, we fixed this in 5 i believe to use the version info from chrome directly. I'll update this.

@nornagon nornagon referenced this pull request Mar 4, 2019

Merged

fix: correct chrome version in chrome_version.h #17218

2 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.