Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate promise functions properly #16643

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

commented Jan 31, 2019

Description of Change

Backport of #16544.

cc @ckerr

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from as a code owner Jan 31, 2019

@codebytere codebytere force-pushed the deprecations-fix branch from c3504a4 to 396fa46 Jan 31, 2019

@ckerr

ckerr approved these changes Feb 1, 2019

@codebytere codebytere force-pushed the deprecations-fix branch from 396fa46 to 81391a7 Feb 1, 2019

@codebytere codebytere merged commit a7ed504 into 5-0-x Feb 1, 2019

9 of 16 checks passed

electron-arm-testing Build #20190201.18 has failed
Details
electron-arm64-testing Build #20190201.17 has failed
Details
appveyor: win-ia32-debug Waiting for AppVeyor build to complete
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
appveyor: win-x64-debug Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-mas-testing Build #20190201.14 succeeded
Details
electron-osx-testing Build #20190201.14 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 1, 2019

No Release Notes

@codebytere codebytere deleted the deprecations-fix branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.