Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use async save dialog for anchor download attribute (4-0-x) #16647

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
4 participants
@poiru
Copy link
Member

poiru commented Jan 31, 2019

Backport of #16612 and #16646

Notes: Fix broken save dialog on macOS for <a> downloads

fix: use async save dialog for anchor download attribute (4-0-x)
Backport of #16612 and #16646

Notes: Fix broken save dialog on macOS for `<a>` downloads

@poiru poiru requested a review from zcbenz Jan 31, 2019

@poiru poiru requested a review from as a code owner Jan 31, 2019

@poiru poiru added the 4-1-x label Jan 31, 2019

@codebytere codebytere added the backport label Feb 2, 2019

@MarshallOfSound MarshallOfSound merged commit c00d353 into 4-0-x Feb 4, 2019

20 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 4, 2019

Release Notes Persisted

Fix broken save dialog on macOS for <a> downloads

@MarshallOfSound MarshallOfSound deleted the download-async-save-dialog-4-0-x branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.