Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add window removeMenu() method (backport: 5-0-x) #16657

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

commented Jan 31, 2019

Backport of #16570

See that PR for details.

Notes: Added win.removeMenu() to remove application menus instead of using win.setMenu(null).

@trop trop bot requested review from as code owners Jan 31, 2019

@trop trop bot referenced this pull request Jan 31, 2019

Merged

feat: add window removeMenu() method #16570

6 of 6 tasks complete

@trop trop bot added 5-0-x backport labels Jan 31, 2019

@codebytere
Copy link
Member

left a comment

Hold for Kickoff vote!

@groundwater
Copy link
Member

left a comment

👍 in weekly kickoff

@@ -659,6 +659,13 @@ void TopLevelWindow::SetMenu(v8::Isolate* isolate, v8::Local<v8::Value> value) {
}
}

void TopLevelWindow::RemoveMenu() {
mate::Handle<Menu> menu;

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Feb 4, 2019

Member

What is the purpose of this variable ?

This comment has been minimized.

Copy link
@codebytere

codebytere Feb 4, 2019

Member

will remove in follow-up

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Feb 4, 2019

Member

Thanks!

@codebytere codebytere merged commit 26e0a7d into electron:5-0-x Feb 4, 2019

6 of 9 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
build-mac-fork-prs Workflow: build-mac-fork-prs
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 4, 2019

Release Notes Persisted

Added win.removeMenu() to remove application menus instead of using win.setMenu(null).

@codebytere codebytere referenced this pull request Feb 4, 2019

Merged

chore: remove unused variable in removeWindow #16715

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.