New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: hack around GitHub upload API failure / flake #16663

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Copy link
Member

MarshallOfSound commented Jan 31, 2019

This is a super hacky workaround to the GitHub API failure. Assuming a case where we want to upload file "X" instead we upload that file to "fake-X-fake-DATE" and then on success, rename that file. This way if a file we upload dies like we have been seeing the "DATE" stamped file name will be broken, not the actual file name we want to end up using.

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Jan 31, 2019

@MarshallOfSound MarshallOfSound force-pushed the hack-around-uploads branch from 8b78428 to b1594db Jan 31, 2019

@BinaryMuse

This comment has been minimized.

Copy link
Member

BinaryMuse commented Jan 31, 2019

@MarshallOfSound What's the plan for dealing with the stale assets that get left in the release?

@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Jan 31, 2019

@BinaryMuse if assets are broken, they won't appear, and if they do appear this handles that!

@BinaryMuse
Copy link
Member

BinaryMuse left a comment

Alright, I'm on board. Nice hack 👍

@codebytere codebytere merged commit ab503c7 into master Jan 31, 2019

4 of 9 checks passed

appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
appveyor: win-x64-debug Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 31, 2019

No Release Notes

@codebytere codebytere deleted the hack-around-uploads branch Jan 31, 2019

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 31, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 31, 2019

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 31, 2019

I was unable to backport this PR to "3-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 31, 2019

I was unable to backport this PR to "2-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 31, 2019

I have automatically backported this PR to "5-0-x", please check out #16665

@codebytere codebytere referenced this pull request Feb 1, 2019

Merged

build: hack around GitHub upload API failure / flake #16667

4 of 4 tasks complete

codebytere added a commit that referenced this pull request Feb 7, 2019

codebytere added a commit that referenced this pull request Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment