New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a new Electron dedicated ABI number for Electron 4.0 #16687

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Copy link
Member

MarshallOfSound commented Feb 1, 2019

This is the outcome of nodejs/TSC#651 and should fix everyone having issues building / using native modules on Electron 4 with strange ABI mis-match issues.

Brings in: electron/node@8bc5d17

Notes: Change the NODE_MODULE_VERSION to 69

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Feb 1, 2019

@codebytere codebytere merged commit abb1a09 into 4-0-x Feb 2, 2019

9 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 2, 2019

Release Notes Persisted

Change the NODE_MODULE_VERSION to 69

@codebytere codebytere deleted the change-abi-number-4 branch Feb 2, 2019

malept added a commit to malept/node-abi that referenced this pull request Feb 3, 2019

malept added a commit to malept/node-abi that referenced this pull request Feb 3, 2019

MarshallOfSound added a commit to lgeiger/node-abi that referenced this pull request Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment