Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional remote APIs filtering (backport: 4-0-x) #16688

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@miniak
Copy link
Contributor

miniak commented Feb 1, 2019

Description of Change

Backport #16293

Checklist

Release Notes

Notes: Allowed filtering of remote.getBuiltin(), remote.getCurrentWindow(), remote.getCurrentWebContents and <webview>.getWebContents().

@miniak miniak requested review from as code owners Feb 1, 2019

@miniak miniak changed the title feat: add additional remote APIs filtering feat: add additional remote APIs filtering (backport: 4-0-x) Feb 1, 2019

@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Feb 2, 2019

Did this already get Kickoff approval?

@miniak

This comment has been minimized.

Copy link
Contributor Author

miniak commented Feb 2, 2019

@codebytere Last time it was inconclusive, I will raise it once more on Monday

@miniak miniak self-assigned this Feb 4, 2019

@MarshallOfSound
Copy link
Member

MarshallOfSound left a comment

Kickoff Approval

@codebytere codebytere merged commit e253c9b into 4-0-x Feb 4, 2019

9 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 4, 2019

Release Notes Persisted

Allowed filtering of remote.getBuiltin(), remote.getCurrentWindow(), remote.getCurrentWebContents and <webview>.getWebContents().

@codebytere codebytere deleted the miniak/remote-handlers-4.0 branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.