Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change of previously wrong added Polish emoji into proper one #16700

Merged
merged 2 commits into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@robertgrzonka
Copy link
Contributor

robertgrzonka commented Feb 2, 2019

Description of Change

Added Polish flag to list of translations

Checklist

Release Notes

Notes: no-notes

Change Polish flag
* Change of previously setuped flag of Monaco to Polish flag

@robertgrzonka robertgrzonka requested a review from as a code owner Feb 2, 2019

@welcome

This comment has been minimized.

Copy link

welcome bot commented Feb 2, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@jkleinsc
Copy link
Contributor

jkleinsc left a comment

@robertgrzonka thank you for your PR. The emoji you removed is for the Indonesian translation which Electron does support. It appears that we did not have a Polish emoji, so instead of replacing the Indonesian one, can you add the Polish one?

fix: change flags
* add Indonesian flag at former place
* append Polish flag at the end
@robertgrzonka
Copy link
Contributor Author

robertgrzonka left a comment

@jkleinsc hello there! Thanks for response. Sorry for my mistake, I was quite sure flag was from Monaco 🇲🇨, didn't even know Indonesia 🇮🇩 had almost the same.

I put Indonesian flag in former place and append Polish flag at the end. Hope everything will work this time :)

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Feb 11, 2019

Merging as CI failures unrelated to doc change.

@jkleinsc jkleinsc merged commit a3cdf46 into electron:master Feb 11, 2019

4 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 11, 2019

Release Notes Persisted

no-notes

@welcome

This comment has been minimized.

Copy link

welcome bot commented Feb 11, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@robertgrzonka robertgrzonka deleted the robertgrzonka:patch-1 branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.