Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify cookies api #16702

Merged
merged 2 commits into from Feb 3, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

commented Feb 2, 2019

Description of Change

Backport of #16464. Necessary to unblock 5-0-x releases due to a versioning conflict in electron-typescript-definitions.

cc @ckerr

Checklist

Release Notes

Notes: Added Promise support for the Cookies API.

feat: promisify cookies api (#16464)
* feat: promisify the Cookie API

* chore: update specs to test promisified cookies

* chore: add deprecate wrapper for cookie callback API

* docs: update docs to cookie promise changes

* chore: remove redundant namespace use

* docs: improve cookie example

* docs: restore docs for cookie callback API

* chore: restore cookie callback tests

* fix: syntax of cookie promise return types

@codebytere codebytere requested review from as code owners Feb 2, 2019

@ckerr

ckerr approved these changes Feb 2, 2019

Copy link
Member

left a comment

Thanks!

@codebytere codebytere merged commit 60af6c2 into 5-0-x Feb 3, 2019

14 of 15 checks passed

Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190202.11 succeeded
Details
electron-arm64-testing Build #20190202.11 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 3, 2019

Release Notes Persisted

Added Promise support for the Cookies API.

@codebytere codebytere deleted the cookies-bp branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.