Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate ServiceWorker APIs #16732

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented Feb 5, 2019

Description of Change

Refs #16717: deprecate ServiceWorker APIs on the WebContents module before their removal in 6.0

cc @deepak1556 @MarshallOfSound

Checklist

Release Notes

Notes: Deprecated ServiceWorker APIs on WebContents in preparation for their removal.

@codebytere codebytere requested a review from as a code owner Feb 5, 2019

@ckerr

ckerr approved these changes Feb 5, 2019

@codebytere codebytere merged commit 64cd5bf into 5-0-x Feb 5, 2019

14 of 16 checks passed

build-linux Workflow: build-linux
Details
electron-arm64-testing Build #20190205.13 has failed
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
electron-arm-testing Build #20190205.13 succeeded
Details
electron-mas-testing Build #20190205.4 succeeded
Details
electron-osx-testing Build #20190205.4 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 5, 2019

Release Notes Persisted

Deprecated ServiceWorker APIs on WebContents in preparation for their removal.

@codebytere codebytere deleted the deprecate-sw branch Feb 5, 2019

@codebytere codebytere referenced this pull request Feb 6, 2019

Merged

chore: add standalone function deprecation helper #16782

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.