Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migration guide for register{StandardSchemes => SchemesAsPrivileged} #16762

Merged
merged 5 commits into from Feb 12, 2019

Conversation

@nornagon
Copy link
Contributor

commented Feb 5, 2019

Description of Change

Added migration guide for protocol.registerStandardSchemes, webFrame.registerURLSchemeAs* and protocol.registerServiceWorkerSchemes.

cc @nitsakh

Checklist

Release Notes

Notes: no-notes

@nornagon nornagon requested a review from as a code owner Feb 5, 2019

Show resolved Hide resolved docs/api/protocol.md Outdated
Show resolved Hide resolved docs/api/protocol.md Outdated

MarshallOfSound and others added some commits Feb 6, 2019

Update docs/api/protocol.md
Co-Authored-By: nornagon <nornagon@nornagon.net>
Update docs/api/protocol.md
Co-Authored-By: nornagon <nornagon@nornagon.net>
@jkleinsc
Copy link
Contributor

left a comment

Overall looks good to me, just a small nit around wording.

Show resolved Hide resolved docs/api/protocol.md Outdated
Update docs/api/protocol.md
Co-Authored-By: nornagon <nornagon@nornagon.net>
@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

Merging as CI failure isn't related to doc change.

@jkleinsc jkleinsc merged commit 5a44cc5 into master Feb 12, 2019

12 of 14 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190212.5 succeeded
Details
electron-arm64-testing Build #20190212.5 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 12, 2019

Release Notes Persisted

no-notes

@jkleinsc jkleinsc deleted the nornagon-patch-2 branch Feb 12, 2019

@deepak1556 deepak1556 referenced this pull request Feb 12, 2019

Merged

chore: fix lint errors #16906

0 of 6 tasks complete

MarshallOfSound added a commit that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.