Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add standalone function deprecation helper #16782

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented Feb 6, 2019

Description of Change

Forward-port of #16732. Adds a standalone function deprecation helper to allow for deprecation of functions either in preparation for their removal or migration to a function with a new name and/or signature.

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from as a code owner Feb 6, 2019

@codebytere codebytere changed the title chore: add standalone function deprecation helper [wip] chore: add standalone function deprecation helper Feb 6, 2019

@codebytere codebytere added the wip label Feb 6, 2019

@codebytere codebytere force-pushed the add-fn-deprecate branch from 1ea9f7e to d8b5dce Feb 6, 2019

@codebytere codebytere changed the title [wip] chore: add standalone function deprecation helper chore: add standalone function deprecation helper Feb 7, 2019

@codebytere codebytere force-pushed the add-fn-deprecate branch from d8b5dce to aa887fd Feb 7, 2019

@codebytere codebytere removed the wip label Feb 7, 2019

@codebytere codebytere force-pushed the add-fn-deprecate branch 2 times, most recently from 34bf839 to 604a648 Feb 7, 2019

@miniak

miniak approved these changes Feb 7, 2019

@codebytere codebytere force-pushed the add-fn-deprecate branch from 604a648 to d0b2d92 Feb 8, 2019

@codebytere codebytere merged commit e790dbd into master Feb 8, 2019

16 checks passed

Artifact Comparison No Changes
Details
Backportable? - 5-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190208.4 succeeded
Details
electron-arm64-testing Build #20190208.4 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 8, 2019

No Release Notes

@codebytere codebytere deleted the add-fn-deprecate branch Feb 8, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

I have automatically backported this PR to "5-0-x", please check out #16833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.