Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Menu.buildFromTemplate() to accept MenuItems (backport: 5-0-x) #16783

Conversation

Projects
None yet
4 participants
@trop
Copy link
Contributor

commented Feb 6, 2019

Backport of #16697

See that PR for details.

Notes: Updated Menu.buildFromTemplate() to allow it to accept MenuItems in addition to plain objects.

@trop trop bot requested review from as code owners Feb 6, 2019

@trop trop bot referenced this pull request Feb 6, 2019

Merged

feat: allow Menu.buildFromTemplate() to accept MenuItems #16697

6 of 6 tasks complete

@trop trop bot added 5-0-x backport labels Feb 6, 2019

@codebytere
Copy link
Member

left a comment

hold for kickoff vote

@groundwater
Copy link
Member

left a comment

Approved pending @BinaryMuse's 👍

@BinaryMuse
Copy link
Member

left a comment

Looks good to me 👍

Approved at kickoff

@codebytere codebytere merged commit 14c3962 into electron:5-0-x Feb 11, 2019

6 of 9 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
build-mac-fork-prs Workflow: build-mac-fork-prs
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 11, 2019

Release Notes Persisted

Updated Menu.buildFromTemplate() to allow it to accept MenuItems in addition to plain objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.