Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: depend on mojo audio and video in BUILD.gn #16785

Merged
merged 1 commit into from Feb 6, 2019
Merged

Conversation

codebytere
Copy link
Member

Description of Change

Follow up for #16763.

We need to depend on
"//services/video_capture/public/mojom:constants"
"//services/audio/public/mojom:constants"
for Electron to build.

cc @brenca

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from a team February 6, 2019 18:27
@codebytere codebytere merged commit 84eef16 into master Feb 6, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 6, 2019

No Release Notes

@trop
Copy link
Contributor

trop bot commented Feb 6, 2019

I have automatically backported this PR to "5-0-x", please check out #16789

@codebytere codebytere deleted the fix-mojo-deps branch February 6, 2019 19:04
@deepak1556
Copy link
Member

@codebytere how did the original PR pass the builds when this was needed ?

@codebytere
Copy link
Member Author

@deepak1556 idk but that concerns me: i checked and they did

@deepak1556
Copy link
Member

deepak1556 commented Feb 7, 2019

They are private deps and the required headers are generated ones, thats why I didn't worry about adding them explicitly. Nevertheless, its good to have them explicitly specified.

//electron:electron_lib --[private]-->
//content/public/app:both --[private]-->
//content/public/utility:utility_sources --[private]-->
//content/utility:utility --[private]-->
//services/video_capture/public/mojom:constants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants