New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set MAS_BUILD=true on mas builds #16824

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Copy link
Member

MarshallOfSound commented Feb 8, 2019

Description of Change

In VSTS we defined MAS_BUILD, and on CircleCI we forgot to do so. This thus fixes MAS releases not being built correctly and published to releases on GitHub.

Release Notes

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Feb 8, 2019

@nornagon

This comment has been minimized.

Copy link
Contributor

nornagon commented Feb 8, 2019

why?

@nornagon
Copy link
Contributor

nornagon left a comment

^

@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

MarshallOfSound commented Feb 8, 2019

@nornagon It is a required environment variable for a bunch of our release scripts and it's the cause of the failed Electron 6.0 nightly release a few hours ago.

See #bot-release

@nornagon nornagon merged commit 23b8491 into master Feb 8, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 8, 2019

No Release Notes

@codebytere codebytere deleted the fix-mas-publish branch Feb 8, 2019

jkleinsc added a commit that referenced this pull request Feb 11, 2019

@jkleinsc jkleinsc referenced this pull request Feb 11, 2019

Merged

ci: Move MacOS builds to CircleCI (5-0-x) #16882

4 of 4 tasks complete

jkleinsc added a commit that referenced this pull request Feb 11, 2019

codebytere added a commit that referenced this pull request Feb 13, 2019

ci: Move MacOS builds to CircleCI (5-0-x) (#16882)
* ci: Put back changes to build mac on CircleCI (#16656)

This reverts commit 3dcb7cf.

* ci: make macOS CI faster (#16766)

* ci: cache brew update result

* ci: checkout and sync the macOS build on a linux machine for speed

* ci: set MAS_BUILD=true on mas builds (#16824)

* build: remove non-arm vstsJobs (#16793)

* ci: fix binaries for chromedriver build on macOS (#16893)

jkleinsc added a commit that referenced this pull request Feb 13, 2019

ci: Move MacOS builds to CircleCI (4-0-x) (#16933)
* ci: build mac on CircleCI (#16656)

* ci: make macOS CI faster (#16766)

* ci: cache brew update result

* ci: checkout and sync the macOS build on a linux machine for speed

* ci: set MAS_BUILD=true on mas builds (#16824)

* build: remove non-arm vstsJobs (#16793)

* ci: fix binaries for chromedriver build on macOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment