Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't construct submenu if it's invisible (backport: 5-0-x) #16846

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Feb 8, 2019

Backport of #16834

See that PR for details.

Notes: Fixed submenus not responding to the visible: false MenuItem property.

@trop trop bot requested a review from as a code owner Feb 8, 2019

@trop trop bot referenced this pull request Feb 8, 2019

Merged

fix: don't construct submenu if it's invisible #16834

5 of 5 tasks complete

@trop trop bot added 5-0-x backport labels Feb 8, 2019

@MarshallOfSound MarshallOfSound merged commit 4079787 into electron:5-0-x Feb 8, 2019

5 of 8 checks passed

build-linux Workflow: build-linux
Details
build-mac-fork-prs Workflow: build-mac-fork-prs
Details
appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 8, 2019

Release Notes Persisted

Fixed submenus not responding to the visible: false MenuItem property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.